Airlock Refactor and Better Naming for Doors In General, Also Firelocks [MDB IGNORE] #521
Conversation
…_arent_shit_anymore
github-actions
bot
added
the
Tools
RimiNosha
removed
the
Merge Conflict
|
Oh fuck |
RimiNosha
changed the title
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself. |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself. |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself. |
UI and helper icons stolen from citadel.
About The Pull Request
Fuck me sideways with a rusty knife, this tested my patience. Anyways, yeah, shitcode obliterated and replaced with my own shitcode that's 100% less likely to randomly hang the server when an airlock gets blown up. You know who you are.
Important terminology changes:
Anyways, you no longer have to fuck around with manually setting vars and subtypes for making airlocks. Instead, it's put together with mapping helpers, like citadel.
How to assemble your own airlock is documented in the readme,
TODO:
How Does This Help Gameplay?
Makes it clear who's talking about what, and makes it so old firelocks aren't going to be as omnipresent. I've future plans for these things that'll entirely remove them outside of large rooms.
Also makes the station more fire and atmos breakage resistant by having cubbies with their own air-maintaining measures scattered around. This is a good thing with ZAS, trust me.
How Does This Help Roleplay?
More immersive ship and station designs, and proper names for everything.
Proof of Testing
Screenshots/Videos
In your fucking dreams, this shit's broke as fuck thanks to my experiments.
Changelog
🆑
add: Firelocks, which are airlocks that auto-deploy when air becomes unsafe.
qol: Airlock doors and firelocks have been renamed.
refactor: Entirely overhauled how airlocks are handled and named. See pr 521 for more info.
/:cl: